Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flag] Add Flag to switch between RLP and other future encoding #88

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

rpl-ffl
Copy link
Collaborator

@rpl-ffl rpl-ffl commented Sep 24, 2024

In anticipation of adding protobuf encoding, a SetSubstateEncoding function is added to SubstateDB.
Currently, only option available is "rlp".
If unset or set to "default", rlp is selected.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Adds or updates testing

@rpl-ffl rpl-ffl force-pushed the rapol/feature/flag-substate-decoder branch from e1c967b to 7f435fb Compare September 25, 2024 03:18
@rpl-ffl rpl-ffl mentioned this pull request Sep 25, 2024
1 task
@rpl-ffl rpl-ffl requested a review from cabrador September 25, 2024 07:12
cabrador
cabrador previously approved these changes Sep 25, 2024
Copy link
Contributor

@cabrador cabrador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding unit tests.
I have small comments about names, otherwise feel free to merge.

db/substate_encoding.go Outdated Show resolved Hide resolved
db/substate_encoding.go Outdated Show resolved Hide resolved
Co-authored-by: cabrador <[email protected]>
@rpl-ffl rpl-ffl requested a review from cabrador September 25, 2024 11:00
@rpl-ffl rpl-ffl merged commit 932f8e2 into main Sep 26, 2024
@rpl-ffl rpl-ffl deleted the rapol/feature/flag-substate-decoder branch September 26, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants